Conversation
No Homebrew tap exists yet (CRY-37), so the GitHub Release binaries are the primary install path for a lot of users right now, not a fallback. Two real gaps: `mix release lc` builds all 3 Burrito targets in one invocation and Burrito builds each independently, so one target could silently fail without failing the whole build - the release could ship missing a binary with no CI signal. And nothing let a downloader verify a binary wasn't corrupted or tampered with in transit. Explicitly verify lc_linux_x86_64 and lc_macos_aarch64 exist post-build, failing loudly (::error::) if either is missing - the guaranteed floor. Windows keeps building for free but isn't asserted on. Generate a SHA256SUMS file covering every artifact that did build, uploaded alongside the binaries. Readme.adoc documents verification on both platforms - shasum -a 256 -c - on macOS (no sha256sum on stock macOS), sha256sum -c - on Linux. Closes #16. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR strengthens the release pipeline by ensuring required Burrito release targets are actually produced before uploading, and by publishing a SHA256SUMS asset so users can verify downloaded binaries.
Changes:
- Add an explicit CI verification step to fail the workflow if required artifacts (
lc_linux_x86_64,lc_macos_aarch64) are missing aftermix release lc. - Generate and upload a
SHA256SUMSfile alongside built release artifacts. - Update
Readme.adocto document checksum verification for release binary downloads.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/burrito-release.yaml |
Adds post-build target existence checks and generates/uploads a SHA256SUMS file with the release artifacts. |
Readme.adoc |
Documents downloading SHA256SUMS and verifying the macOS binary checksum before installing/renaming. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+47
to
+51
| $ curl -sLO https://github.com/rubyists/linear-cli-ex/releases/latest/download/lc_macos_aarch64 | ||
| $ curl -sLo SHA256SUMS https://github.com/rubyists/linear-cli-ex/releases/latest/download/SHA256SUMS | ||
| $ grep lc_macos_aarch64 SHA256SUMS | shasum -a 256 -c - <1> | ||
| $ chmod +x lc_macos_aarch64 | ||
| $ sudo mv lc_macos_aarch64 /usr/local/bin/lc |
A grep miss piping empty input into the checker isn't safe to skip - sha256sum -c - (the Linux equivalent) exits 0 on empty input, so a typo'd filename would silently "pass" without checking anything at all. Guard with grep -q ... && first. Also trims the accompanying footnote back down to the platform-command difference alone - the rationale belongs here in the commit message, not as an implementation essay in the Readme itself. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #16.
No Homebrew tap exists yet (CRY-37), so the GitHub Release binaries are the primary install path for a lot of users right now, not a fallback. Two real gaps in
burrito-release.yaml:mix release lcbuilds all 3 Burrito targets in one invocation, and Burrito builds each target independently, so one target failing partway through wouldn't necessarily fail the wholemix releaseinvocation - the release could ship missing a binary with no CI signal. Now explicitly verifieslc_linux_x86_64andlc_macos_aarch64exist post-build, failing loudly (::error::) if either is missing - the guaranteed floor. Windows keeps building for free (the step already installs p7zip for it) but isn't asserted on.SHA256SUMSfile covering every artifact that actually built, uploaded alongside the binaries.Readme.adoc's "Download a release binary" section documents verification on both platforms -shasum -a 256 -c -on macOS (stock macOS has nosha256sum),sha256sum -c -on Linux.Test plan
ruby -ryaml)app/burrito_out/lc_macos_aarch64/lc_linux_x86_64) - confirmedshasum -a 256 -c -andsha256sum -c -both correctly verify agrep'dSHA256SUMSlineshasum -cfails looking for a file that no longer exists under that nameReadme.adocstill renders cleanly (asciidoctor -o /dev/null)SHA256SUMSasset attached🤖 Generated with Claude Code